Skip to content

#17 - Refactor Firebase Processing Logic #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

#17 - Refactor Firebase Processing Logic #18

wants to merge 1 commit into from

Conversation

@godpp
Copy link
Member

@godpp godpp commented Aug 12, 2020 •
edited
Loading

#17

Background

  • 현재 계층화 되지 않은 Remote 모듈에 대해 계층화를 통해 Success, Error Handling에 대해 용이하게 하기 위함
  • 추후 Framework로 Remote 모듈을 개발하기 위한 사전 작업

Task 1 - Firebase 모듈화 작업

  • FirebaseClient
    • Firebase Instance를 통해 직접 Remote하는 wrapping class
  • FirebaseResult
    • Firebase Remote 결과를 처리하는 Generic Enum
  • FirebaseDecoder
    • Model Decoder

Task 2 - Firebase Database Path

  • static property로 관리

Task 3 - Firebase Login Flow 개선

  • Account Type과 로그인 결과 로직 분리

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needTesting refactor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@godpp