[fix] main과 운영에서 캐릭터 촬영 제거 - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
캐릭터 촬영 기능은 develop에만 남겨야 하지만, 활동 로그 작업의 develop 병합으로 main에 유입되어 재배포 시 운영에 노출됐다. main에서 촬영 기능을 제거한다.
변경 내용
검증
npm run lint && npm run typecheck && npm test && npm run build통과 (단위 테스트 14개)TEST_BASE_URL=http://127.0.0.1:4317 node --env-file=../../.env.test ../../node_modules/@playwright/test/cli.js test production-boundary.spec.ts통과git diff --check통과화면
제한 및 배포
사용자 요청대로 main에 병합 후 프로덕션 재배포한다. develop 전체를 main에 병합하면 촬영 기능이 재유입될 수 있으므로 이 회귀 테스트와 변경 범위를 확인해야 한다.
Closes #17