Skip to content

Package list: ignore modifier key press#3344

Merged
Martí Climent (marticliment) merged 4 commits intoDevolutions:mainfrom
tkohlmeier:improve-package-list-keyboard-search
Feb 26, 2025
Merged

Package list: ignore modifier key press#3344
Martí Climent (marticliment) merged 4 commits intoDevolutions:mainfrom
tkohlmeier:improve-package-list-keyboard-search

Conversation

@tkohlmeier
Copy link
Copy Markdown
Contributor

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

Currently, pressing Control, Shift or Alt key results in selecting the first item in a package list. This PR fixes this by only handling [a-z0-9] keys.

@marticliment
Copy link
Copy Markdown
Collaborator

Will test and merge later

@tkohlmeier
Copy link
Copy Markdown
Contributor Author

Found an even better solution. The CharacterReceived event seems to be exactly what is needed here.

@mrixner
Copy link
Copy Markdown
Contributor

mrixner commented Feb 25, 2025

Yeah, I kind of patched this together. Thank you for improving it!

@marticliment Martí Climent (marticliment) merged commit fecaf3d into Devolutions:main Feb 26, 2025
2 checks passed
@tkohlmeier tkohlmeier deleted the improve-package-list-keyboard-search branch February 26, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants