Skip to content

Fix the Improved Icon Detection #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Martí Climent (marticliment) merged 2 commits into from
Feb 26, 2025
Merged

Fix the Improved Icon Detection #3347

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce54672
Fix the improved icon detection
mrixner Feb 22, 2025
9d6c108
Merge branch 'main' into improve-icon-detection
mrixner Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/UniGetUI.PackageEngine.PackageManagerClasses/Packages/Package.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,13 +100,18 @@ public Package(

_iconId = Manager.Name switch
{
"Winget" => string.Join('.', id.ToLower().Split(".")[1..]),
"Winget" => Source.Name switch
{
"Steam" => id.ToLower().Split("\\")[^1].Replace("steam app ", "steam:").Trim(),
"Local PC" => id.ToLower().Split("\\")[^1],
"Microsoft Store" => id.IndexOf('_') < id.IndexOf('.') ? // If the first underscore is before the period, this ID has no publisher
string.Join('_', id.ToLower().Split("\\")[1].Split("_")[0..^4]) : // no publisher: remove `MSIX\`, then the standard ending _version_arch__{random id}
string.Join('_', string.Join('.', id.ToLower().Split(".")[1..]).Split("_")[0..^4]), // remove the publisher (before the first .), then the standard _version_arch__{random id}
_ => string.Join('.', id.ToLower().Split(".")[1..]),
},
"Scoop" => id.ToLower().Replace(".app", ""),
"Chocolatey" => id.ToLower().Replace(".install", "").Replace(".portable", ""),
"vcpkg" => id.ToLower().Split(":")[0].Split("[")[0],
"Steam" => id.ToLower().Split("\\")[^1].Replace("Steam App", "steam:"),
"Local PC" => id.ToLower().Split("\\")[^1],
"Microsoft Store" => id.ToLower().Split(".")[1].Split("_")[0],
_ => id.ToLower()
};
}
Expand Down
Loading