Strip .git extension from scoop source URLs#3383
Merged
Martí Climent (marticliment) merged 2 commits intoDevolutions:mainfrom Mar 1, 2025
Merged
Strip .git extension from scoop source URLs#3383Martí Climent (marticliment) merged 2 commits intoDevolutions:mainfrom
.git extension from scoop source URLs#3383Martí Climent (marticliment) merged 2 commits intoDevolutions:mainfrom
Conversation
Fixes Devolutions#3367 Will be rendered redundant and should be reverted if ScoopInstaller/Scoop#6297 is addressed directly by Scoop.
SierraKomodo (SierraKomodo)
force-pushed
the
fix/scoop-source-urls
branch
from
f4638c5 to
d374431
Compare
Contributor
Author
|
Regex was slightly malformed yet still functioned. Funny but oops. |
Collaborator
|
Thanks! I will test and merge later today. |
Martí Climent (marticliment)
approved these changes
Mar 1, 2025
Martí Climent (marticliment)
merged commit 2cd76b8
into
Devolutions:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
Uses regex to remove
.gitfrom the end of Scoop source URLs, so that generated manifest links in package information are valid.The specific regex pattern
^(.*)\.git$is used in case of urls in custom buckets having.gitin the domain name. I.e.,someguy.gitrepo.tld. The only part that needs to be removed here is the suffix if present.Will be rendered redundant and should be reverted if ScoopInstaller/Scoop#6297 is addressed directly by Scoop.
Fixes #3367