feat(deps)!: upgrade odm layer to MongDB Rust driver v3.0.0 #30
Conversation
douggynix
changed the title
douggynix
changed the title
Since we are still pre 1.0.0, it's fine to bump the minor number only. Cargo is treating those as breaking. Co-authored-by: Benoît Cortier <[email protected]>
|
@CBenoit : I am done with my changes. Feel free to do the last reviews for refactoring if needed in order to have it merged. |
|
Any update or another review to have this merged? |
| let index_doc = if index.keys.iter().any(|ind| matches!(ind, IndexKey::TextIndex(_))) { | ||
| let index_doc = if index | ||
| .keys | ||
| .iter() | ||
| .any(|ind| matches!(ind, IndexKey::TextIndex(_))) | ||
| { |
There was a problem hiding this comment.
question: Do you know why the formatting was changed here? Is it the result of cargo fmt using the stable channel? I see other similar places.
There was a problem hiding this comment.
The formatting has been changed due to cargo.
I just ran cargo fmt as simple as that and it reformats it that way automatically.
cargo fmt --verbose I am using rust tool chains version 1.79.0
There was a problem hiding this comment.
Sounds good. I just realized that our CI was dead and we were not checking the formatting anymore.
There was a problem hiding this comment.
I noticed the CI was dead as well. We can address it from another PR or this one?
There was a problem hiding this comment.
I opened a PR for that already: #31
CBenoit
changed the title
This pull request is related to that issue below I have opened to switch to the newer version of Mongodb Rust Driver v3.0.0
Issue : #29
Mongodb team introduced a lot of broken changes as a regard to the former api in 2.x. Some methods have their arguments reduced, or some errors have been renamed. A lot of refactoring resulted in having build errors for features that have been also removed in Cargo.
This pull request is opened to address those.
I have run the Unit test and it ran successfully. Feel free to review, fix, accept or deny this PR.
Here is one of the PR from Mongodb Driver Rust team from which originates those broken changes from the APIs: mongodb/mongo-rust-driver#1046
FindOptions, FindOneOptions and so on are removed from find method arguments and encapsulated by chain calling explicitly a with_options()
Additional PR from mongodb rust team with broken changes from the former 2.x api: //See driver pull request change for errors: mongodb/mongo-rust-driver#1102