Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix success job #32

Merged
merged 1 commit into from
Jul 17, 2024
Merged

ci: fix success job #32

merged 1 commit into from
Jul 17, 2024

Conversation

CBenoit
Copy link
Member

@CBenoit CBenoit commented Jul 16, 2024

GitHub considers skipped jobs as fulfilling requirements when merging pull requests. We need to ensure that the success job fails if any previous job has failed.

GitHub considers skipped jobs as fulfilling requirements when merging
pull requests. We need to ensure that the succeeding job fails if any
previous job has failed.
@CBenoit CBenoit requested a review from a team as a code owner July 16, 2024 03:39
@CBenoit CBenoit enabled auto-merge (squash) July 16, 2024 03:40
@CBenoit CBenoit merged commit 681c29a into master Jul 17, 2024
4 checks passed
@CBenoit CBenoit deleted the ci/fix-success-job branch July 17, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants