simplify calculations#17
Open
jaihindhreddy wants to merge 3 commits intoDevonCrawford:masterfrom
jaihindhreddy:simplify
Open
simplify calculations#17jaihindhreddy wants to merge 3 commits intoDevonCrawford:masterfrom jaihindhreddy:simplify
jaihindhreddy wants to merge 3 commits intoDevonCrawford:masterfrom
jaihindhreddy:simplify
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've made some changes which simplify the script. The details are in chronological order of commits:
Some if statements can be removed because of the two following properties of the log function:
This means you don't need to check if the old and the new values are equal, or find out which is greater than the other.
Removed unused setter methods. These can be added if and when necessary.
The ExposureChange and TemperatureChange classes aren't that different from each other, and can be eliminated by having a magnitude property in the Change class itself.
The printing of Changes can also be moved into a toString method on the Change class, and that pulls the NumToName method in there with it. This also means that private properties can be directly accessed eliminating more getter methods in the Change class.
Also, the constructor can take the magnitude of the change making the setter for magnitude redundant.