Smooth normal calculation Update! #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

devshgraphicsprogramming merged 53 commits into master from smooth_normal_calculation

Nov 7, 2025

Member

devshgraphicsprogramming commented Oct 21, 2025

Description

Testing

TODO list:

kevyuu added 11 commits

September 18, 2025 13:31


          Remove wage and store weighted normal instead

efa37a7


          Move getAngleWeight to hlsl/shapes/triangle.hlsl

cc4a219


          Refactor erase to resize

c018762


          Remove parentTriangleFaceNormal from SSNGVertexData

42ccf48


          Refactor getNeighboringCells

05ee8ed


          Slight improvement for readability

f4b8ac6


          Refactor Radix Sorter and use histogram as skip list

0dd02e8


          Move VertexHashMap into its own file

ce99287


          Refactor smooth normal generator to use VertexHashGrid and separate w…

28f73f5

…eldVertices into CVertexWelder


          Fix normal comparison to use dot instead of value by value comparison

5acb40d


          Merge branch 'master' into smooth_normal_calculation

0feb4e9

devshgraphicsprogramming commented

View reviewed changes

include/nbl/builtin/hlsl/shapes/triangle.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/builtin/hlsl/shapes/triangle.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/builtin/hlsl/shapes/triangle.hlsl Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/core/algorithm/radix_sort.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CPolygonGeometryManipulator.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/core/algorithm/radix_sort.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/core/algorithm/radix_sort.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexHashGrid.h Outdated Show resolved Hide resolved

kevyuu added 2 commits

November 3, 2025 16:12


          Fix variable and function specifier

0cdf7e8


          Fix the patchedEpsilon

4dbcbeb

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CPolygonGeometryManipulator.h Outdated Show resolved Hide resolved

kevyuu added 7 commits

November 3, 2025 18:31


          Remove inline specifier for function that is defined in cpp

ff42165


          Remove forEachBroadphaseNeighborCandidates overload that takes vertex…

94c65b6

… as argument


          Add inline specifier for method in CVertexWelder

38ef627


          Refactor class name for SSNGVertexData

bfba9fa


          Add inline specifier for DefaultWeldPredicate constructor and destructor

f3d9a19


          Remove outdated TODO

f5d38f2


          Slight refactor for SSNGVertexData alias

cc39901

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Outdated Show resolved Hide resolved

devshgraphicsprogramming commented

View reviewed changes

include/nbl/asset/utils/CVertexWelder.h Show resolved Hide resolved

kevyuu and others added 7 commits

November 6, 2025 22:04


          Add comment to implement a class template of CVertexHashGrid and CSmo…

1257d4d

…othNormalGenerator that take position as template argument


          Add some assert in isAttributeValEqual and isAttributeDirEqual

d2503af


          Cache channelCount and byte size in init

1386fba


          Fix weldVertices

ac2ed54


          Small fixes in CVertexWelder

fe55595


          fix compiler warning


          Update CSmoothNormalGenerator.cpp

bd102e4

Resolve #941 (comment)

devshgraphicsprogramming merged commit 378108d into master

7 of 8 checks passed

devshgraphicsprogramming deleted the smooth_normal_calculation branch

November 7, 2025 10:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet