Final BxDF changes, drafts of Spherical Shape Sampling, RWMC and PAth Tracing #966
+2,047
−272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/nbl/builtin/hlsl/sampling/projected_spherical_triangle.hlsl
Outdated
Show resolved
Hide resolved
Comment on lines
+89
to
+90
| shapes::SphericalTriangle<T> tri; | ||
| sampling::SphericalTriangle<T> sphtri; |
Member
Author
There was a problem hiding this comment.
you only need the sampling::SphericalTriangle
13 tasks
devshgraphicsprogramming
changed the title
so CI logs are easier to Ctrl+F
…racer_example_no_quat
devshgraphicsprogramming
deleted the
hlsl_path_tracer_example_no_quat
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
TODO list:
Fix everything from Iridescent fresnel, bxdfs #918Fix everything from Hlsl path tracer example #947Deferred PRs (more work will be done in them)
LoadableImageandResolveAccessorBaseconcepts #964