fix: statusline setup nudge honors CLAUDE_CONFIG_DIR#338
Open
Lakshya77089 wants to merge 1 commit into
Open
Conversation
The activation hook detects a missing statusline in getClaudeDir()/settings.json (CLAUDE_CONFIG_DIR-aware) but the nudge text told the user and the agent to add the statusLine config to ~/.claude/settings.json. With CLAUDE_CONFIG_DIR set, that is the wrong file: Claude Code never reads it and the badge never turns on. Point the nudge at the settingsPath the hook already computed, in both the shell-safe and manual branches. Fixes DietrichGebert#250
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250.
#34 made
ponytail-activate.jsdetect a missing statusline ingetClaudeDir()/settings.json(so it honorsCLAUDE_CONFIG_DIR), but the user-facing setup nudge still hardcoded~/.claude/settings.jsonin both branches:"To enable, add this to ~/.claude/settings.json: ""...to ~/.claude/settings.json, quoting/escaping the path for your shell."So when
CLAUDE_CONFIG_DIRpoints elsewhere, ponytail correctly notices the missing statusline in the custom dir, then tells the user (and the agent) to write the config into~/.claude/settings.json— the wrong file. The badge never activates and the agent edits a file Claude Code is not reading.This points the nudge at the
settingsPaththe hook already computes, so it matches where the statusline is actually detected. Sibling to the read-path fix in #154.Verified: extended the existing
CLAUDE_CONFIG_DIRtest to assert the nudge references<CLAUDE_CONFIG_DIR>/settings.json. Full suite green; no behavior change whenCLAUDE_CONFIG_DIRis unset (nudge then resolves to the home~/.claude/settings.jsonpath as before).