fix(benchmarks): match CRLF code fences in loc.js#340
Open
Lakshya77089 wants to merge 1 commit into
Open
Conversation
The fenced-block regex had no \r? before \n, so CRLF output ( ```js\r\n ) matched no block and the metric fell back to counting the whole response, prose and fences included. correctness.js already handles \r?\n; align loc.js with it and add a CRLF regression case. Fixes DietrichGebert#339
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339.
loc.jsextracts code blocks with/```[a-zA-Z0-9_+-]* ([\s\S]*?)```/g— no?before the```js) never matches. With no block found it falls back to counting the entire response, prose and fence lines included.correctness.jsalready handles this with?, so on CRLF input the LOC metric and the correctness gate disagree. This alignsloc.jswith it.Before:
After: both score 2.
Added a CRLF case to
benchmarks/loc.test.js(now 6/6). LF input is unaffected; one-token regex change.