fix: correct CSV sum regex to use \d instead of [\\d]#368
Open
nanaubusiness wants to merge 2 commits into
Open
fix: correct CSV sum regex to use \d instead of [\\d]#368nanaubusiness wants to merge 2 commits into
nanaubusiness wants to merge 2 commits into
Conversation
added 2 commits
June 27, 2026 19:52
Previously '/ponytail:review' fell to getDefaultMode() instead of activating review mode, because the condition checked for the unreachable '/ponytail:ponytail-review' (wrong pattern). Also removes the unreachable disjunct that could never be matched. Closes DietrichGebert#361
In correctness.js, [\\d] in a raw string creates a character class matching a literal backslash or 'd', not a digit. The intended lookbehind/lookahead (?<!\d) and (?!\d) now work correctly. Closes DietrichGebert#365
This was referenced Jun 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
benchmarks/correctness.js, the character class[\\d]in a Python raw string matches a literal backslash or 'd', not a digit. The intended lookbehind/lookahead(?<!\d)and(?!\d)now work correctly to detect the standalone number 351 in CSV sum output.Closes #365