fix: add 'rate limiting' to identifyTask for correctness gate#382
Closed
nanaubusiness wants to merge 1 commit into
Closed
fix: add 'rate limiting' to identifyTask for correctness gate#382nanaubusiness wants to merge 1 commit into
nanaubusiness wants to merge 1 commit into
Conversation
The benchmark prompt uses 'rate limiting' (with ING) but identifyTask only checked 'rate limit' and 'rate-limit'. The correctness gate was silently skipped for rate limit tasks. Closes DietrichGebert#372
Owner
|
Thanks for the PR! Current main already classifies this correctly: identifyTask matches the substring 'rate limit', and since 'rate limiting'.includes('rate limit') is true the task is already picked up (benchmarks/correctness.js:31 also handles the 'rate-limit' form). So this change is redundant now. Closing alongside #372, but thanks for catching and following up on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark prompt uses 'rate limiting' (with ING) but identifyTask only checked 'rate limit' and 'rate-limit'. The correctness gate was silently skipped for rate limit tasks.
Closes #372