fix: add error handling to setMode + check all 6 copilot commands#394
Open
nanaubusiness wants to merge 1 commit into
Open
fix: add error handling to setMode + check all 6 copilot commands#394nanaubusiness wants to merge 1 commit into
nanaubusiness wants to merge 1 commit into
Conversation
- hooks/ponytail-runtime.js: wrap setMode writeFileSync in try/catch so disk full or permission errors don't crash the hook - tests/copilot-plugin.test.js: check all 6 TOML files, not just 4 Closes DietrichGebert#378, Closes DietrichGebert#381
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes:
hooks/ponytail-runtime.js: wrap setMode writeFileSync in try/catch so disk full/permission errors don't crash the hook (Closes hooks/ponytail-runtime.js: setMode has no try/catch — disk full crashes hook #378)tests/copilot-plugin.test.js: check all 6 TOML files, not just 4 (Closes tests/copilot-plugin.test.js: only checks 4 of 6 commands for TOML file presence #381)