Skip to content

Register strategy as custom dashboard#323

Draft
balloob wants to merge 8 commits into
DigiLive:mainfrom
balloob:patch-1
Draft

Register strategy as custom dashboard#323
balloob wants to merge 8 commits into
DigiLive:mainfrom
balloob:patch-1

Conversation

@balloob

@balloob balloob commented May 6, 2026

Copy link
Copy Markdown

@codacy-production

codacy-production Bot commented May 6, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@balloob balloob marked this pull request as draft May 6, 2026 16:32
@balloob balloob marked this pull request as ready for review May 6, 2026 17:18
@DigiLive

DigiLive commented May 9, 2026

Copy link
Copy Markdown
Owner

On hold for a little while.

It's a good addition to the strategy, but it reintroduces the issue of discussion #292.

I can't find a clear root cause for the options not being stored.
HASS developers have been changing a lot regarding Dashboards, Views and Editors, aren't clear about what has been changed, backwards (in)compatibility and it seems like it's not fully finished yet.

So far, one workaround I've found is to rename from options to something else, but I have to research if this is a proper solution or if it requires other changes.

@balloob If you like, I can still do a review so this PR to finish it. However, the merge will have to wait untill the main branch is ready for it.

@DigiLive DigiLive self-requested a review May 10, 2026 05:25
DigiLive

This comment was marked as resolved.

…ine registration (#1)

* Address PR comments: update registration and add getCreateSuggestions

Agent-Logs-Url: https://github.com/balloob/mushroom-strategy/sessions/14d9436e-b60e-49fc-a266-0fcc30e46b63

Co-authored-by: balloob <1444314+balloob@users.noreply.github.com>

* Add Window interface type declaration for customStrategies

Co-authored-by: balloob <1444314+balloob@users.noreply.github.com>

---------

Co-authored-by: anthropic-code-agent[bot] <242468646+Claude@users.noreply.github.com>
Co-authored-by: balloob <1444314+balloob@users.noreply.github.com>
@balloob

balloob commented May 11, 2026

Copy link
Copy Markdown
Author

I've allowed edits by maintainers, feel free to push 👍

DigiLive and others added 5 commits May 11, 2026 12:57
Build artifacts should not be committed.
- Introduce the CustomStrategyEntry interface to represent entries in
  the custom Lovelace strategy registry.
- Extend the global Window interface to include a property for these
  registered custom strategies, enhancing the integration with Home
  Assistant's dashboard capabilities.
Remove the global Window type declaration for custom strategies as it's
declared in another file already.
@DigiLive DigiLive dismissed their stale review May 15, 2026 15:12

Outdated

@DigiLive DigiLive marked this pull request as draft May 15, 2026 15:12
@DigiLive DigiLive self-assigned this May 15, 2026
@DigiLive DigiLive added the enhancement New feature or request label May 15, 2026
@DigiLive

Copy link
Copy Markdown
Owner

On hold for #323 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Register as dashboard strategy

3 participants