Conversation
…pportunities Move the extents of non-root aligned subtrees (vertical-align: top | bottom) out of LineBoxMetrics into BreakerState::subtrees, and save/restore that list alongside the line state in PrevBoundaryState. LineBoxMetrics is now Copy, and the list is empty (so cloning it is free) unless the line has top/bottom aligned content.
|
I'll fix CI failures and address comments from users with write access that start with 'Devin'.
|
# Conflicts: # parley/src/layout/line_break.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LLM Contributions: Code and tests written by Devin (LLM), at the request of @nicoburns.
Description to be written by a human author per the LLM policy. Alternative to linebender#855.
Changelog: None
Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/29f0d07ee02848d2b3c41820ec7f2c04
Open in Devin Desktop: https://dioxus.staging.devinenterprise.com/desktop/session/29f0d07ee02848d2b3c41820ec7f2c04?variant=devin-insiders