Skip to content

test: cover create_vault amount boundaries#250

Closed
dangelo352 wants to merge 2 commits into
Disciplr-Org:mainfrom
dangelo352:feature/amount-boundary-proptests-231
Closed

test: cover create_vault amount boundaries#250
dangelo352 wants to merge 2 commits into
Disciplr-Org:mainfrom
dangelo352:feature/amount-boundary-proptests-231

Conversation

@dangelo352

Copy link
Copy Markdown

Summary

  • keep randomized success sampling on the valid interior while preserving explicit MIN_AMOUNT/MAX_AMOUNT edge tests
  • assert MIN_AMOUNT - 1, MAX_AMOUNT + 1, zero, and negative amounts return Error::InvalidAmount
  • document the amount-boundary strategy and funding separation in TESTING_GUIDE.md

Closes #231

Validation

  • cargo test --test proptest_amounts -- --nocapture
  • cargo test
  • rustfmt tests/proptest_amounts.rs
  • git diff --check

Note: cargo fmt --check currently reports a pre-existing formatting diff in tests/proptest_timestamps.rs, which this PR does not modify.

@1nonlypiece

Copy link
Copy Markdown
Contributor

hey, good work, but this can't go in until you're assigned to #231 — that's our process to avoid two people on the same thing. closing for now; claim the issue first and re-raise. https://discord.gg/xvNAvMJf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add MAX_AMOUNT and MIN_AMOUNT boundary tests for create_vault in tests/proptest_amounts.rs

2 participants