Skip to content

test: cover validate milestone scoped authorization#251

Closed
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/validate-auth-negative-tests-228
Closed

test: cover validate milestone scoped authorization#251
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/validate-auth-negative-tests-228

Conversation

@dangelo352

Copy link
Copy Markdown

Summary

  • add scoped-auth tests for validate_milestone with Some(verifier), None, and Some(creator)
  • prove stranger-signed validation attempts fail and leave vaults active/unvalidated
  • cover authorized success paths and the expired-vault auth-before-expiry ordering
  • document the negative authorization coverage in TESTING_GUIDE.md and TEST_VERIFIER_SAME_AS_CREATOR.md

Closes #228

Validation

  • cargo test --test validate_auth -- --nocapture
  • cargo test
  • cargo fmt --check
  • git diff --check

@1nonlypiece

Copy link
Copy Markdown
Contributor

thanks for jumping on this. #228 hasn't been assigned to you though, and we need the PR author claimed on the issue before review. closing as invalid for now — grab #228 on the board and raise it again. https://discord.gg/xvNAvMJf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add authorization-failure tests for validate_milestone verifier vs non-verifier

2 participants