Skip to content

fix: allow permissionless release after deadline#253

Closed
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/permissionless-post-deadline-release-235
Closed

fix: allow permissionless release after deadline#253
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/permissionless-post-deadline-release-235

Conversation

@dangelo352

Copy link
Copy Markdown

Summary

  • remove the unconditional creator authorization from release_funds
  • document the final authorization matrix: permissionless after deadline, permissionless after successful validation, rejected before validation/deadline
  • add focused auth tests for no-auth post-deadline release, no-auth pre-validation rejection, and no-auth post-validation release
  • add docs/RELEASE_AUTH.md and testing guide notes

Closes #235

Validation

  • cargo fmt --check
  • cargo test
  • git diff --check

Note: local cargo tarpaulin --config tarpaulin.toml --out Stdout is unavailable because cargo-tarpaulin is not installed in this environment; CI coverage should run the repository coverage workflow.

@1nonlypiece

Copy link
Copy Markdown
Contributor

appreciate the effort on this — but #235 isn't assigned to you, and we ask contributors to get assigned to an issue before raising a PR. closing as invalid; please claim #235 on the board first, then open it again and we'll take a proper look. https://discord.gg/xvNAvMJf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Decouple release_funds authorization from creator.require_auth to match the documented "anyone can release after deadline" rule

2 participants