Skip to content

feat: enforce verifier address distinctness#254

Closed
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/verifier-address-distinctness-225
Closed

feat: enforce verifier address distinctness#254
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/verifier-address-distinctness-225

Conversation

@dangelo352

Copy link
Copy Markdown

Summary

  • add Error::ConflictingAddresses without renumbering existing contract errors
  • reject create_vault when verifier equals success_destination or failure_destination before escrow transfer
  • preserve verifier == creator and no-verifier destination-overlap behavior
  • document the address matrix in docs/ADDRESS_CONSTRAINTS.md and link it from README
  • update contract-interface.json error metadata

Closes #225

Validation

  • cargo fmt --check
  • cargo test
  • git diff --check

Note: local cargo tarpaulin --config tarpaulin.toml --out Stdout is unavailable because cargo-tarpaulin is not installed in this environment; CI coverage should run the repository coverage workflow.

@1nonlypiece

Copy link
Copy Markdown
Contributor

hey, good work, but this can't go in until you're assigned to #225 — that's our process to avoid two people on the same thing. closing for now; claim the issue first and re-raise. https://discord.gg/xvNAvMJf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate verifier and destination addresses are distinct in create_vault

2 participants