Skip to content

fix: enforce checks-effects-interactions ordering#255

Closed
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/cei-reentrancy-ordering-234
Closed

fix: enforce checks-effects-interactions ordering#255
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/cei-reentrancy-ordering-234

Conversation

@dangelo352

Copy link
Copy Markdown

Summary

  • marks release, redirect, and cancel vaults terminal before invoking the external token transfer
  • adds terminal-state regression coverage proving second release/redirect/cancel paths do not pay another balance delta
  • documents the reentrancy threat model and links it from the USDC integration notes

Closes #234

Validation

  • cargo fmt --check
  • git diff --check
  • cargo test

@1nonlypiece

Copy link
Copy Markdown
Contributor

thanks for jumping on this. #234 hasn't been assigned to you though, and we need the PR author claimed on the issue before review. closing as invalid for now — grab #234 on the board and raise it again. https://discord.gg/xvNAvMJf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add reentrancy-safe checks-effects-interactions ordering to release_funds and redirect_funds

2 participants