Skip to content

feat: add bounded protocol fee settlement#260

Closed
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/protocol-fee-219
Closed

feat: add bounded protocol fee settlement#260
dangelo352 wants to merge 1 commit into
Disciplr-Org:mainfrom
dangelo352:feature/protocol-fee-219

Conversation

@dangelo352

Copy link
Copy Markdown

Summary

  • add per-vault ProtocolFeeConfig with bounded fee_bps and fee_recipient
  • apply checked, rounded-up protocol fee splitting in both release_funds and redirect_funds
  • emit fee_collected for non-zero fees and preserve exact zero-fee settlement behavior
  • update ABI metadata, README/backend docs, and add docs/FEES.md

Closes #219

Validation

  • cargo fmt --check
  • cargo test --test fees -- --nocapture
  • cargo test
  • cargo clippy --all-targets --all-features -- -D warnings

@1nonlypiece

Copy link
Copy Markdown
Contributor

thanks for the work here — but our flow is that you need to be assigned to the issue before opening a PR for it. #219 isn't assigned to you, so i'm closing this as invalid for now. please claim #219 first (comment on the issue or grab it on the GrantFox board), then re-raise and we'll review right away. https://discord.gg/xvNAvMJf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a protocol fee on release_funds and redirect_funds in src/lib.rs

2 participants