Feature/bulk milestone checkin#956
Merged
1nonlypiece merged 2 commits intoJun 29, 2026
Merged
Conversation
Add POST /api/verifications/bulk endpoint that accepts multiple check-in submissions in a single request. Each item is validated and applied independently; failures are reported per-item without aborting the entire batch. - Add bulk check-in endpoint to src/routes/verifications.ts - Reuse existing validation/authorization from single check-in - Enforce batch size cap (100 items) - Return per-item success/error results with summary - Add comprehensive tests in src/tests/verifications.bulk.test.ts - Document in docs/milestones.md Per-item isolation ensures one bad item never aborts the batch. Idempotency support via existing VerificationConflictError handling.
Revert validation errors to throw instead of return next() to ensure per-item isolation. Using return next() would abort the entire batch on the first validation error, violating the partial-failure requirement.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| if (!Array.isArray(items)) { | ||
| return next(AppError.badRequest('Request body must be an array of check-in items')) | ||
| } |
|
|
||
| const cleanTargetId = targetId.trim() | ||
| const cleanEvidenceReferenceUrl = evidenceReferenceUrl.trim() | ||
|
|
|
@Simongodw Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #851
#851 Add bulk milestone check-in submission with partial-failure reporting
Summary
Adds POST
/api/verifications/bulkendpoint that accepts multiple milestone check-in submissions in a single request. Each item is validated and applied independently; failures are reported per-item without aborting the entire batch.Changes
Key Features
Testing
All edge cases covered:
Checklist