Test/queryparser injection#966
Open
wonderfulmarv01 wants to merge 3 commits into
Open
Conversation
- Implemented GET /api/orgs/:orgId/analytics/risk endpoint to retrieve risk metrics for organizations. - Added logic to calculate slash rate and capital at risk based on vault data. - Introduced new OrgRiskAnalyticsVault and OrgRiskAnalyticsResponse interfaces for structured data handling. - Created unit tests to validate the new endpoint functionality and ensure accurate metric calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #735
PR Description
Summary
This PR adds focused regression tests for the query parser to ensure it rejects prototype-pollution keys and unsafe operator injection while still accepting valid filters.
What changed
Added injection and prototype-pollution coverage for the query parser middleware.
Added service-level parser coverage to verify unsafe keys and unsupported operators are handled safely.
Hardened the service parser to sanitize protected keys such as proto, constructor, and prototype before building filter conditions.
Why
The query parser previously had no dedicated tests proving that it rejects malicious query keys and unsafe filter operators. This left a gap around prototype pollution and filter bypass scenarios. These tests now lock in the expected behavior and reduce the chance of regressions.
Tests
Verified with:
bun test src/tests/queryParser.injection.test.ts
Result
Prototype-pollution keys are rejected
Unsupported operators and unknown fields are ignored/rejected
Valid filters still parse correctly