fix: fix unit tests and FHIR service method signature mismatches#3
Open
dac-ai-worker wants to merge 1 commit into
Open
fix: fix unit tests and FHIR service method signature mismatches#3dac-ai-worker wants to merge 1 commit into
dac-ai-worker wants to merge 1 commit into
Conversation
Separate unit and integration test suites — unit tests run without a database via bootstrap-unit.php (autoloaders only), integration tests still require OpenEMR Docker. Fix LibraryAssetFHIRResourceServiceTest extending Monolog\Test\TestCase instead of PHPUnit\Framework\TestCase. Fix createOpenEMRSearchParameters signature in 4 FHIR service classes to match parent ResourceServiceSearchTrait. Bump to v0.11.0. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
composer testruns unit tests without a database,composer test-integrationrequires OpenEMR Dockertests/bootstrap-unit.phpthat loads only autoloaders (module + parent) withoutglobals.phpLibraryAssetFHIRResourceServiceTestextendingMonolog\Test\TestCaseinstead ofPHPUnit\Framework\TestCasecreateOpenEMRSearchParameterssignature in 4 FHIR service classes to match parentResourceServiceSearchTrait(addarray,?string,: arraytype hints)Test plan
composer testpasses (4 tests, 16 assertions, 1 incomplete)composer test-integrationruns correctly in Docker environment🤖 Generated with Claude Code