Feat openemr 9877 ccda tests

.composer-require-checker.json

@@ -5,6 +5,8 @@
     "BillingExport",
     "C_Document",
     "Carecoordination\\Model\\CarecoordinationTable",
+    "Carecoordination\\Model\\CcdaGenerator",
+    "Carecoordination\\Model\\EncounterccdadispatchTable",
     "FPDF_FONTPATH",
     "GenericProductRegistrationException",
     "IS_WINDOWS",
@@ -27,6 +29,7 @@
     "areCredentialsCreated",
     "buildTemplate",
     "checkUserSetting",
+    "check_code_set_filters",
     "csv_like_join",
     "display_layout_tabs",
     "display_layout_tabs_data",

.dclintrc.yaml

@@ -10,7 +10,7 @@ rules:
   service-image-require-explicit-tag: 0
   no-unbound-port-interfaces: 0
   require-quotes-in-ports: 0
-  
+
   # Alphabetical ordering rules are kept as warnings
   services-alphabetical-order: 1
   service-ports-alphabetical-order: 1

.editorconfig

@@ -7,7 +7,7 @@ indent_style = space
 indent_size = 4
 trim_trailing_whitespace = true
 
-[*.{json,jsn,sh,yaml,yml}]
+[*.{json,jsn,sh,yaml,yml,neon,neon.dist}]
 indent_size = 2
 
 [composer.{json,lock}]

.github/FUNDING.yml

@@ -11,4 +11,4 @@ issuehunt: # Replace with a single IssueHunt username
 otechie: # Replace with a single Otechie username
 custom: ["https://www.open-emr.org/donate/"]
 #bitcoin: 3GCNLbiZmHP26fA77NkLgY4tKdEts3ADQg
-#ethereum: 0xcD7542b2DcF41072aC7783C7cbc31B0f1E257E80 
+#ethereum: 0xcD7542b2DcF41072aC7783C7cbc31B0f1E257E80

.github/ISSUE_TEMPLATE/bug_report.md

@@ -30,5 +30,3 @@ Steps to reproduce the behavior:
 
 <!-- Love openemr? Please consider supporting our project:
 👉  https://github.com/sponsors/openemr -->
-
-

.github/PULL_REQUEST_TEMPLATE.md

@@ -1,4 +1,4 @@
-<!--Thanks for sending a pull request! 
+<!--Thanks for sending a pull request!
 Please create an issue at https://github.com/openemr/openemr/issues/new/choose and then
 -->
 

.github/workflows/composer.yml

@@ -54,7 +54,7 @@ jobs:
       run: composer install --prefer-dist --no-progress
 
     - name: "Validate Composer"
-      run: composer validate
+      run: composer validate --strict
 
     - name: "Check Composer Normalized"
       run: composer normalize --dry-run

.github/workflows/docker-compose-lint.yml

@@ -5,20 +5,10 @@ on:
     branches:
     - master
     - rel-*
-    paths:
-    - '**/*compose*.yml'
-    - '**/*compose*.yaml'
-    - '.github/workflows/docker-compose-lint.yml'
-    - '.dclintrc.yaml'
   pull_request:
     branches:
     - master
     - rel-*
-    paths:
-    - '**/*compose*.yml'
-    - '**/*compose*.yaml'
-    - '.github/workflows/docker-compose-lint.yml'
-    - '.dclintrc.yaml'
 
 permissions:
   contents: read
@@ -34,7 +24,7 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v6
-    
+
     - name: Get changed docker compose files
       id: changed-files
       continue-on-error: true
@@ -45,12 +35,12 @@ jobs:
           **/*compose*.yaml
         files_ignore: |
           .github/**
-    
+
     - name: Determine files to check
       id: files-to-check
       run: |
         set -x
-        
+
         # If the changed-files step failed or returned empty,
         # use find to locate all docker compose files in the repo.
         if [[ "${{ steps.changed-files.outcome }}" = success && "${{ steps.changed-files.outputs.any_changed }}" = true ]]; then
@@ -63,13 +53,13 @@ jobs:
           # Use recursive mode in dclint to find all compose files
           echo "mode=recursive" >> "$GITHUB_OUTPUT"
         fi
-    
+
     - name: Run dclint on changed files
       if: steps.files-to-check.outputs.mode == 'files'
       run: |
-        docker run --rm --volume "$PWD:$PWD" --workdir "$PWD" zavoloklom/dclint:3.1.0 --exclude .github ${{ steps.files-to-check.outputs.files }}
-    
+        docker run --rm --volume "$PWD:$PWD" --workdir "$PWD" zavoloklom/dclint:3.1.0 ${{ steps.files-to-check.outputs.files }} --exclude .github
+
     - name: Run dclint recursively
       if: steps.files-to-check.outputs.mode == 'recursive'
       run: |
-        docker run --rm --volume "$PWD:$PWD" --workdir "$PWD" zavoloklom/dclint:3.1.0 --exclude .github --recursive ci/ docker/
+        docker run --rm --volume "$PWD:$PWD" --workdir "$PWD" zavoloklom/dclint:3.1.0 ci/ docker/ --recursive --exclude .github

.github/workflows/hadolint.yml

@@ -32,7 +32,7 @@ jobs:
     steps:
     - name: Checkout code
       uses: actions/checkout@v6
-    
+
     - name: Get changed Dockerfile files
       id: changed-files
       # We run hadolint on all Dockerfiles in the repo
@@ -43,7 +43,7 @@ jobs:
       with:
         files: |
           **/Dockerfile*
-    
+
     - name: Run hadolint on changed files
       if: ${{ steps.changed-files.outcome == 'success' && steps.changed-files.outputs.any_changed == 'true' }}
       env:
@@ -52,14 +52,14 @@ jobs:
         # Safely handle changed files list using environment variable
         # Convert space-separated list to newline-separated for safe parsing
         mapfile -t files < <(echo "$CHANGED_FILES" | tr ' ' '\n')
-        
+
         echo "Linting ${#files[@]} changed Dockerfile(s)..."
         for file in "${files[@]}"; do
           [[ -n "$file" ]] || continue
           echo "Checking: $file"
           docker run --rm -i -v "$(pwd)/.hadolint.yaml:/.config/hadolint.yaml" hadolint/hadolint < "$file"
         done
-    
+
     - name: Run hadolint on all files
       if: ${{ steps.changed-files.outcome != 'success' || steps.changed-files.outputs.any_changed != 'true' }}
       run: |

.github/workflows/phpstan.yml

@@ -69,15 +69,14 @@ jobs:
     # Generate baseline only if analyze step failed
     - name: PHPStan Baseline
       if: steps.phpstan-analyze.outcome == 'failure'
-      run: vendor/bin/phpstan --memory-limit=8G --generate-baseline=baseline.neon
+      run: composer run phpstan-baseline
       continue-on-error: true
-    # Upload baseline only if baseline.neon file exists
     - name: Upload PHPStan Baseline
-      if: hashFiles('baseline.neon') != ''
+      if: steps.phpstan-analyze.outcome == 'failure'
       uses: actions/upload-artifact@v6
       with:
         name: phpstan-baseline-php${{ matrix.php-version }}
-        path: baseline.neon
+        path: .phpstan/phpstan-*-baseline.neon
       continue-on-error: true
     - name: Check PHPStan Results
       if: steps.phpstan-analyze.outcome == 'failure'

.github/workflows/whitespace.yml

@@ -0,0 +1,49 @@
+name: Whitespace
+
+on:
+  push:
+    branches:
+    - master
+    - rel-*
+  pull_request:
+    branches:
+    - master
+    - rel-*
+
+permissions:
+  contents: read
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.ref }}-${{ github.event_name == 'pull_request' && github.event.number || github.run_id }}
+  cancel-in-progress: ${{ github.event_name == 'pull_request' }}
+
+jobs:
+
+  whitespace:
+    runs-on: ubuntu-24.04
+    name: Check whitespace
+    steps:
+    - name: Checkout code
+      uses: actions/checkout@v6
+    - name: Install Python
+      uses: actions/setup-python@v5
+      with:
+        python-version: '3.12'
+    - name: Install pre-commit
+      run: pip install pre-commit
+    - name: Get changed files (PR only)
+      if: github.event_name == 'pull_request'
+      id: changed-files
+      uses: tj-actions/changed-files@v47
+    - name: Run whitespace hooks (PR - changed files only)
+      if: github.event_name == 'pull_request' && steps.changed-files.outputs.any_changed == 'true'
+      run: |
+        pre-commit run trailing-whitespace --files ${{ steps.changed-files.outputs.all_changed_files }}
+        pre-commit run end-of-file-fixer --files ${{ steps.changed-files.outputs.all_changed_files }}
+        pre-commit run mixed-line-ending --files ${{ steps.changed-files.outputs.all_changed_files }}
+    - name: Run whitespace hooks (push - all files)
+      if: github.event_name == 'push'
+      run: |
+        pre-commit run --all-files trailing-whitespace
+        pre-commit run --all-files end-of-file-fixer
+        pre-commit run --all-files mixed-line-ending

.hadolint.yaml

@@ -6,35 +6,35 @@ ignored:
   # DL3003: Use WORKDIR to switch to a directory
   # Many of our existing Dockerfiles use cd in RUN commands for complex build processes
   - DL3003
-  
+
   # DL3006: Always tag the version of an image explicitly
   # Some base images (osixia/openldap, nginx) are intentionally using latest
   - DL3006
-  
+
   # DL3008: Pin versions in apt-get install
   # Pinning apt versions can make maintenance difficult and break builds
   - DL3008
-  
+
   # DL3009: Delete the apt lists after installing something
   # Some Dockerfiles deliberately keep apt lists for development purposes
   - DL3009
-  
+
   # DL3015: Avoid additional packages by specifying --no-install-recommends
   # Some builds intentionally include recommended packages
   - DL3015
-  
+
   # DL4006: Set the SHELL option -o pipefail before RUN with a pipe
   # Adding pipefail to all existing RUN commands would be intrusive
   - DL4006
-  
+
   # SC2086: Double quote to prevent globbing and word splitting
   # Many existing scripts use intentional word splitting
   - SC2086
-  
+
   # SC2046: Quote this to prevent word splitting
   # Many existing scripts use intentional word splitting
   - SC2046
-  
+
   # DL3020: Use COPY instead of ADD for files and folders
   # Some existing Dockerfiles use ADD for local files
   - DL3020

.phpstan/ForbiddenFunctionsRule.php

@@ -1,10 +1,11 @@
 <?php
 
 /**
- * Custom PHPStan Rule to Forbid Legacy SQL Functions in Modern Code
+ * Custom PHPStan Rule to Forbid Legacy Functions in Modern Code
  *
- * This rule prevents use of legacy sql.inc.php functions in the src/ directory.
- * Contributors should use QueryUtils or DatabaseQueryTrait instead.
+ * This rule prevents use of:
+ * - Legacy sql.inc.php functions (use QueryUtils or DatabaseQueryTrait instead)
+ * - Legacy call_user_func and call_user_func_array (use modern PHP syntax instead)
  *
  * @package   OpenEMR
  * @author    Michael A. Smith <michael@opencoreemr.com>
@@ -42,6 +43,8 @@ class ForbiddenFunctionsRule implements Rule
         'sqlStatementNoLog' => 'Use QueryUtils::fetchRecordsNoLog() instead of sqlStatementNoLog().',
         'sqlStatementThrowException' => 'Use QueryUtils::sqlStatementThrowException() instead of global sqlStatementThrowException().',
         'sqlQueryNoLog' => 'Use QueryUtils::querySingleRow() instead of sqlQueryNoLog().',
+        'call_user_func' => 'Use uniform variable syntax $callable(...$args) or the argument unpacking operator instead of call_user_func().',
+        'call_user_func_array' => 'Use uniform variable syntax $callable(...$args) or the argument unpacking operator instead of call_user_func_array().',
     ];
 
     public function getNodeType(): string
@@ -68,6 +71,17 @@ public function processNode(Node $node, Scope $scope): array
 
         $message = self::FORBIDDEN_FUNCTIONS[$functionName];
 
+        // Determine error identifier and tip based on function type
+        if (in_array($functionName, ['call_user_func', 'call_user_func_array'])) {
+            return [
+                RuleErrorBuilder::message($message)
+                    ->identifier('openemr.legacyCallUserFunc')
+                    ->tip('Example: $myFunction(...$args) or [$object, \'method\'](...$args)')
+                    ->build()
+            ];
+        }
+
+        // Default for SQL functions
         return [
             RuleErrorBuilder::message($message)
                 ->identifier('openemr.deprecatedSqlFunction')

.phpstan/MIGRATION_GUIDE.md

@@ -82,12 +82,12 @@ use OpenEMR\Core\OEGlobalsBag;
 class MyService
 {
     private OEGlobalsBag $globals;
-    
+
     public function __construct(OEGlobalsBag $globals)
     {
         $this->globals = $globals;
     }
-    
+
     public function doSomething(): void
     {
         $setting = $this->globals->get('some_setting');
@@ -209,7 +209,7 @@ class MyServiceTest extends TestCase
             'some_setting' => 'test value',
             'timeout' => 60
         ]);
-        
+
         $service = new MyService($testGlobals);
         // Test your service
     }

.phpstan/MIGRATION_GUIDE_CURL.md

@@ -79,7 +79,7 @@ try {
     $response = $client->request('POST', 'https://api.example.com/endpoint', [
         'json' => $data  // Automatically sets Content-Type and encodes JSON
     ]);
-    
+
     $result = json_decode($response->getBody()->getContents(), true);
 } catch (GuzzleException $e) {
     error_log("HTTP Error: " . $e->getMessage());
@@ -163,7 +163,7 @@ try {
             'Authorization' => 'Bearer ' . $token
         ]
     ]);
-    
+
     $data = json_decode($response->getBody()->getContents(), true);
 } catch (\Exception $e) {
     error_log("HTTP request failed: " . $e->getMessage());