Skip to content

Fix: Memoize NetworkContext value to prevent unnecessary re-renders #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VineetC137 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Memoize NetworkContext value to prevent unnecessary re-renders #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 29 additions & 14 deletions stablepay-sdk/src/contexts/NetworkContext.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
import React, { createContext, useState, useContext, useEffect } from 'react';
import React, {
createContext,
useState,
useContext,
useEffect,
useMemo
} from 'react';
import { TokenSelector } from '../core/TokenSelector';

const NetworkContext = createContext();
Expand All @@ -17,7 +23,7 @@ export const NetworkProvider = ({ children, networkSelector }) => {
const selectNetwork = (networkKey) => {
if (networkSelector.selectNetwork(networkKey)) {
setSelectedNetwork(networkKey);
resetState();
resetState();
return true;
}
return false;
Expand All @@ -43,18 +49,27 @@ export const NetworkProvider = ({ children, networkSelector }) => {
setSelectedNetwork(networkSelector.selectedNetwork);
}, [networkSelector.selectedNetwork]);

// ✅ FIX: Memoize context value to prevent unnecessary re-renders
const contextValue = useMemo(() => ({
networkSelector,
tokenSelector,
selectedNetwork,
selectedToken,
transactionDetails,
setTransactionDetails,
selectNetwork,
selectToken,
resetSelections
}), [
networkSelector,
tokenSelector,
selectedNetwork,
selectedToken,
transactionDetails
]);

return (
<NetworkContext.Provider value={{
networkSelector,
tokenSelector,
selectedNetwork,
selectedToken,
transactionDetails,
setTransactionDetails,
selectNetwork,
selectToken,
resetSelections
}}>
<NetworkContext.Provider value={contextValue}>
{children}
</NetworkContext.Provider>
);
Expand All @@ -68,4 +83,4 @@ export const useNetwork = () => {
return context;
};

export default NetworkContext;
export default NetworkContext;