Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensible download name #1256

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

abhaysp95
Copy link

This PR is meant for review purpose only as it's not complete yet

Feature Description

Allow user to toggle the setting to download the file with sensible file name.

What's the problem

NOTE: I'm taking the image as example for downloadable media for now

Previously the downloaded files where stored with the format subredditname + id, which in some cases (mentioned down below), didn't make much sense (visible in below image)

photo_2022-11-29_11-36-24

What's the fix

Provide user with toggle to enable this feature

photo_2022-11-29_11-36-48

Now, the downloaded files are provided with the post title too

photo_2022-11-29_11-36-43

Why is the feature necessary

  • You want to search some downloaded media in your heap of already downloaded media in your storage. It will be easy if user can find the files by just typing some letter/words in filter of their file explorer/gallery
  • Can write some scripts/tools to re-organize the downloaded media on the basis of the names by applying different sort of grouping techniques (helpful when gallery type images are downloaded, so user can group them with post names)

NOTE: I was not able to downloaded images from gallery post (multiple images post). Is it not implemented ?

@abhaysp95
Copy link
Author

The branch used to make PR sensible_download_name, is based on 234bd7a

@Turhvjbufv
Copy link

@Docile-Alligator can you please take a look at this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants