Skip to content

fix(#573): Guard null assertion crash risk in MultiSigSetup.tsx #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
llinsss merged 1 commit into from
Jun 25, 2026
Merged

fix(#573): Guard null assertion crash risk in MultiSigSetup.tsx #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/Wallet/MultiSigSetup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,11 +68,12 @@ export default function MultiSigSetup({
}

function validateSigners(): string | null {
if (!wallet) return null;
for (const s of signers) {
if (!s.publicKey.trim()) return 'All signers must have a public key.';
if (!s.publicKey.startsWith('G') || s.publicKey.length !== 56)
return `"${s.publicKey.slice(0, 12)}…" is not a valid Stellar public key (must start with G, 56 chars).`;
if (s.publicKey === wallet!.publicKey)
if (s.publicKey === wallet.publicKey)
return "Don't add your own key as a co-signer — adjust the master weight instead.";
if (s.weight < 0 || s.weight > 255) return 'Signer weight must be between 0 and 255.';
}
Expand Down
Loading