fix(#575): Type Recharts formatter/label props in chart components (remove any)#636
Merged
Merged
Conversation
Types the Tooltip formatter value as number|string in FinancialReportChart and introduces a PieLabelProps interface for the renderCustomizedLabel callback in PetHealthChart, removing both any usages and the eslint-disable comment that was suppressing the original warning.
llinsss
approved these changes
Jun 25, 2026
|
@Inkman007 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formattercallback value typed asnumber | stringinstead ofany— matches the actual values Recharts passes and whatNumber(value)expectsPieLabelPropsinterface for the fields used inrenderCustomizedLabel(cx,cy,midAngle,innerRadius,outerRadius,percent) — removes both theanyparameter and theeslint-disable-next-linecomment that was suppressing the warningChanges
src/components/analytics/FinancialReportChart.tsx—(value: any)→(value: number | string)src/components/analytics/PetHealthChart.tsx—PieLabelPropsinterface added,(props: any)removed, eslint-disable comment removedTest plan
$valuestsc --noEmitpasses with no errors on both modified filesCloses #575