fix: guard wallet null in TransactionSigning before signing#650
Merged
llinsss merged 3 commits intoJun 26, 2026
Merged
Conversation
Add a runtime null check in handleSend before accessing wallet.publicKey, replacing the unsafe non-null assertion. Also disable the submit button when wallet is absent, and bump prettier to ^3.8.0 (3.9.0 does not exist on npm, which was breaking npm ci). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@Damidesign Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
llinsss
approved these changes
Jun 26, 2026
Resolves the package-lock.json modify/delete conflict by regenerating the lockfile with npm install against the corrected package.json (prettier ^3.8.0, fixing the npm ci ETARGET failure on main). Deleting the lockfile outright was tested and does not fix CI: npm ci requires a lockfile to exist at all, and restoring main's stale lockfile as-is also fails npm ci (it's missing many transitive entries, unrelated to prettier). A freshly generated lockfile is the only option that verifiably passes npm ci locally.
llinsss
added a commit
to Xaxxoo/petChain-Frontend
that referenced
this pull request
Jun 26, 2026
Resolves the package-lock.json modify/delete conflict the same way as DogStark#650: regenerated the lockfile with npm install rather than keeping it deleted (npm ci requires a lockfile to exist, and main's own lockfile is independently out of sync regardless). Also resolves a real content conflict in package.json's devDependencies. While doing so, deduplicated a pre-existing mess already on main: roughly half of devDependencies were listed twice with conflicting versions (e.g. two 'prettier', two 'ts-jest', two '@types/jest' entries) -- valid JSON since duplicate keys silently take the last value, but clearly the result of an earlier improperly-resolved merge. Kept each key once, using whichever version was already the effective (last-listed, i.e. actually-installed) one on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #568
closes #569
closes #571
closes #572