Skip to content

Fix/polling timeout interval leak tsnocheck logging#682

Merged
llinsss merged 4 commits into
DogStark:mainfrom
OxDev-max:fix/polling-timeout-interval-leak-tsnocheck-logging
Jun 30, 2026
Merged

Fix/polling timeout interval leak tsnocheck logging#682
llinsss merged 4 commits into
DogStark:mainfrom
OxDev-max:fix/polling-timeout-interval-leak-tsnocheck-logging

Conversation

@OxDev-max

Copy link
Copy Markdown
Contributor

closes #671
closes #672
closes #673
closes #674


FILES CHANGED:

  • backend/src/modules/blockchain/stellar.service.ts
  • backend/src/modules/email/email.service.ts
  • backend/src/modules/medical-records/medical-records.controller.ts
  • backend/src/modules/blockchain/blockchain-sync.service.ts
  • backend/src/modules/blockchain/hash-anchoring.service.ts
  • backend/src/modules/blockchain/contract-management.service.ts
  • backend/src/modules/blockchain/contract-interaction.service.ts
  • backend/src/modules/blockchain/payment-automation.service.ts
  • backend/src/modules/stellar-wallet-management/stellar-wallet-management.service.ts
  • backend/src/auth/auth.service.ts
  • backend/src/auth/services/email.service.ts
  • backend/src/modules/users/services/file-upload.service.ts

What was fixed:

  1. Soroban polling loop timeout (stellar.service.ts:210-221) — Added maxPollingAttempts = 30 counter; throws a descriptive error after 30 attempts (~30 seconds) instead of looping forever.
  2. Email interval leak (email.service.ts) — Added OnModuleDestroy interface and onModuleDestroy() method that calls clearInterval(this.processorInterval), preventing dangling timers on teardown/hot-reload.
  3. @ts-nocheck removal — Removed the directive from medical-records.controller.ts and all 7 blockchain/wallet/stellar-wallet-management service files, restoring TypeScript type checking to these high-risk modules. (Note: wallets.service.ts is gitignored and couldn't be committed, but the directive was removed locally.)
  4. console.* → Logger — Replaced all raw console.error/console.log calls in auth.service.ts (3 occurrences), auth/services/email.service.ts (4 occurrences), and file-upload.service.ts (1 occurrence) with NestJS Logger instances, routing output through the structured logging pipeline.

@drips-wave

drips-wave Bot commented Jun 30, 2026

Copy link
Copy Markdown

@OxDev-max Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@llinsss llinsss merged commit c335c33 into DogStark:main Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants