Fixed select trigger bug

Dogfalo · Jun 17, 2018 · d1c369c · d1c369c · pbsdpk · Jun 18, 2018
1 parent 93edc1b
commit d1c369c
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/js/select.js b/js/select.js
@@ -135,8 +135,9 @@
         }
 
         // Set selected on original select option
-        // Check if clicking on already selected option
-        if (!$(this._valueDict[key].el).prop('selected')) {
+        // Only trigger if selected state changed
+        let prevSelected = $(this._valueDict[key].el).prop('selected');
+        if (prevSelected !== selected) {
           $(this._valueDict[key].el).prop('selected', selected);
           this.$el.trigger('change');
         }