NEW Init externalModules Class to Fetch Modules from Multiple Sources #33156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeweerd
reviewed
Feb 20, 2025
| if (!isset($a[$key]) || !isset($b[$key])) { | ||
| return 0; | ||
| } | ||
| /** @var array<string, mixed> $a */ |
There was a problem hiding this comment.
You need to define these as parameters of a function, just before function.
return
/**
* @param ...
* @param ...
* @return
*/
function()...
mdeweerd
reviewed
Feb 20, 2025
| $error_message = $error_messages[$request['status_code']] ?? 'Unexpected HTTP status: ' . $request['status_code']; | ||
|
|
||
| // Append error details if available | ||
| if (!empty($request['response']) && isset($request['response']['errors']) && is_array($request['response']['errors'])) { |
There was a problem hiding this comment.
It is indicated that 'response' is a string. So to fix that you need to suggest it is response:?array{errors:string[]} or response:null|string|array{errors:string[]} if it can also be a string.
|
Thanks @mdeweerd ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR initializes the externalModules class to fetch modules from multiple sources and adapts it to the new Dolistore API