NEW #33506 Add a constant to apply a ratio to resize images in ODT templates #33543
+201
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in ODT templates A new Dolibarr constant MAIN_DOC_ODT_IMAGE_RATIO is taken in consideration for ODT templates. This constant holds a number that is multiplied when computing the size of images in ODT templates. All doc_generic_*_odt_modules.php files have been updated to call the setImage Method with a new parameter $ratio The method setImage in the file odt.php has been modified to have a new parameter $ratio and use it to compute the image size
some other files needed to be changed in the develop branch
eldy
reviewed
Mar 20, 2025
| @@ -530,7 +530,7 @@ public function preOdfToOdf($value) | |||
| * @throws OdfException | |||
| * @return odf | |||
| */ | |||
| public function setImage($key, $value) | |||
| public function setImage($key, $value, float $ratio=1) | |||
There was a problem hiding this comment.
You must add the parameter $ratio into the doc comment.
@param float $ratio Ratio for image
eldy
added
the
PR to fix - See feedback in comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new Dolibarr constant MAIN_DOC_ODT_IMAGE_RATIO.
This constant holds a number that is multiplied when computing the size of images in ODT templates.
All doc_generic_*_odt_modules.php files have been updated to call the setImage Method with a new parameter $ratio.
The method setImage in the file odt.php and segment.php has been modified to have a new parameter $ratio and use it to compute the image size