Update Resend template with optional CAA record#990
Open
cassiozen wants to merge 3 commits intoDomain-Connect:masterfrom
Open
Update Resend template with optional CAA record#990cassiozen wants to merge 3 commits intoDomain-Connect:masterfrom
cassiozen wants to merge 3 commits intoDomain-Connect:masterfrom
Conversation
|
✅ JSON Filename Check Passed |
|
✅ JSON Schema Validation Passed |
Linter OK
|
| Level | Code | Note |
|---|---|---|
| info | DCTL1016 | unexpeceted record type |
resend.com.mail.json
| Level | Code | Note |
|---|
PR Description Check PassedAll required sections are filled in correctly. Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates resend.com.click-tracking.json (v1 → v2):
Some registrars (e.g. Vercel) auto-create restrictive CAA records on domains, which blocks Amazon CloudFront from issuing the SSL certificate needed for the click-tracking reverse proxy.
The CAA record is in its own
caagroup (separate fromclick-tracking) so we can only apply it when needed.Updates resend.com.mail.json (v5 → v6):
Templates updated:
resend.com.mail.jsonv5 → v6resend.com.click-tracking.jsonv1 → v2Type of change
How Has This Been Tested?
<providerId>.<serviceId>.jsonlogoUrlis actually served by a webserverChecklist of common problems
Mark all the checkboxes after conducting the check. Comment on any point which is not fulfilled.
See Template Quality Guidelines for details and rationale on each rule.
syncPubKeyDomainis set — this is mandatory; omitting it requires explicit justification in the PR description or the PR will be rejectedwarnPhishingis not set alongsidesyncPubKeyDomain— the two must not appear togethersyncRedirectDomainis set whenever the template usesredirect_uriin the synchronous flow"v=spf1 ...") — use theSPFMrecord type insteadtxtConflictMatchingModeis set on every TXT record that must be unique per label or content prefix (e.g. DMARC) — N/A, no TXT records added@ TXT "%foo%") unless necessary — CAA value is fully static (0 issue "amazon.com")hostlabel — CAA record uses@, no variableshostfield to create a subdomain — CAA record uses@, no variables%host%does not appear explicitly in anyhostattributeessentialis set toOnApplyon records the end user may need to modify or remove without breaking the template (e.g. DMARC) — N/A, no DMARC or user-modifiable recordsOnline Editor test results
Editor test link(s):
For
resend.com.click-tracking.jsonsolo click tracking subdomain flow: Test resend.com/click-tracking example.com/@
solo click tracking subdomain flow (w/ Host): Test resend.com/click-tracking example.com/newsletter
solo click tracking subdomain + CAA flow Test resend.com/click-tracking example.com/@
For
resend.com.mail.json(logo update)Test resend.com/mail example.com/newsletter
Test resend.com/mail example.com/@