Skip to content

adds more tech-y welding goggles - #1156

Open
carda-sometimesknownas-paxilmaniac wants to merge 4 commits into
DopplerShift13:masterfrom
carda-system:super-welding-mask
Open

adds more tech-y welding goggles#1156
carda-sometimesknownas-paxilmaniac wants to merge 4 commits into
DopplerShift13:masterfrom
carda-system:super-welding-mask

Conversation

@carda-sometimesknownas-paxilmaniac

Copy link
Copy Markdown
Collaborator

About The Pull Request

image

They behave nearly identical to welding goggles, just looking cooler

Why It's Good For The Game

I love welding goggles but also I want something that looks cooler

Changelog

🆑
add: Adds high tech welding goggles as a visor
/:cl:

@github-actions github-actions Bot added Sprites Funny little pixels on our screen Feature Something new, something fresh. labels Jul 25, 2026

@TheOneAndOnlyCreeperJoe TheOneAndOnlyCreeperJoe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanna quickly verify you're not unnecessarily defining these.

icon_state = "techweld"
worn_icon = 'modular_doppler/super_glasses/icons/worn/visors.dmi'
inhand_icon_state = "welding-g"
supported_bodyshapes = null

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I missing something, aren't these null already or are we modularly defining these on glasses?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modularly overwritten as most glasses have a teshari icon, whereas I have never made a teshari sprite in my life and will not

worn_icon = 'modular_doppler/super_glasses/icons/worn/visors.dmi'
inhand_icon_state = "welding-g"
supported_bodyshapes = null
bodyshape_icon_files = null

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature Something new, something fresh. Sprites Funny little pixels on our screen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants