Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Chore update storybook #1580

Merged
merged 21 commits into from
May 5, 2023
Merged

[WIP] Chore update storybook #1580

merged 21 commits into from
May 5, 2023

Conversation

pointhalo
Copy link
Collaborator

@pointhalo pointhalo commented Apr 28, 2023

中文模板 / Chinese Template

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Test Case
  • TypeScript definition update
  • Document improve
  • CI/CD improve
  • Branch sync
  • Other, please describe:

PR description

  1. 升级 storybook版本,原低版本 storybook 基于 webpack4,现根目录 webpack锁定v5后,storybook无法跑起、导致 e2e cyprss 也无法运行
  1. 升级 babel相关依赖版本
  2. 升级 ci 相关镜像 node 版本
  3. 解决升级后更严格的ts类型检查报错问题

Checklist

  • Test or no need
  • Document or no need
  • Changelog or no need

Other

  • Skip Changelog

Additional information

@pointhalo pointhalo changed the base branch from main to release April 28, 2023 04:01
@github-actions github-actions bot added the codeball:approved Codeball label Apr 28, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1232094:

Sandbox Source
pr-story Configuration
Semi Design: Simple Story Configuration

@pointhalo pointhalo changed the title Chore update storybook [WIP] Chore update storybook Apr 28, 2023
@pointhalo
Copy link
Collaborator Author

image
需要更新 Cypress Image,过低 node Js 版本无法运行 storybook react v7

@pointhalo
Copy link
Collaborator Author

image

CI Codesandbox 中 gatsby svgr 相关插件 peer version未满足。该插件最近一年已未更新,但 peer 与 readme 描述有区别,readme中 for gatsby v2,pacakge.json require gatsby v3
image

@pointhalo
Copy link
Collaborator Author

pointhalo commented May 4, 2023

  1. lerna bootstrap -- --legacy-peer-deps
  2. 降低 gatsby plugin svgr 版本,均无效。仍然有同样报错,且本地无法复现,可能CI 上有构建缓存

@pointhalo
Copy link
Collaborator Author

pointhalo commented May 4, 2023

  1. lerna bootstrap -- --legacy-peer-deps
  2. 降低 gatsby plugin svgr 版本,均无效。仍然有同样报错,且本地无法复现,可能CI 上有构建缓存

不起作用是因为原 pacakge.json 中 npm i lerna 没有 -g,lerna 作为项目依赖安装。

// package.json scripts
- install:codesandbox:  npm i lerna && lerna bootstrap
+ install:codesandbox:  npm i lerna -g && lerna bootstrap

@pointhalo
Copy link
Collaborator Author

pointhalo commented May 4, 2023

问题

解决 peer Dependency conflict 后,新的问题为 ts type check fail

image

解决方案

  • 修改 overflowList 、table foundation type define

@pointhalo
Copy link
Collaborator Author

问题

babel/types升级 7.21.0后, babel-plugin-lodash (gatsby的依赖)使用的 babel/types,存在废弃 API warning

image

解决方案

package.json Show resolved Hide resolved
@pointhalo pointhalo merged commit 1a02e8f into release May 5, 2023
@pointhalo pointhalo deleted the chore-updateStorybook branch May 5, 2023 12:46
@pointhalo pointhalo restored the chore-updateStorybook branch May 5, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants