perf: avoid smart money OBV allocation#18
Open
stmr wants to merge 1 commit into
Open
Conversation
|
@stmr is attempting to deploy a commit to the dragoon4002's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid materializing a full OBV series inside the smart-money strategy. The strategy only needs to know whether OBV increased over the trailing
obv_window, so this computes that trailing delta directly.Type
Related Issue
Related to #2.
Changes
_obv_series(...)with_obv_trending_up(...)inapp/strategies/quant_algos/smart_money.py.obv[-1] > obv[-(obv_window + 1)]is equivalent to trailing OBV delta> 0.Testing
python3 -m py_compile app/strategies/quant_algos/smart_money.pygit diff --checksmart_money(...)calls after patch: 0.0133sChecklist
docs/connections/service-map.mdupdated (if adding a new call path) - not applicabledocs/architecture/data-model.mdupdated (if changing DB schema) - not applicableapp/strategies/signals.py(if adding a strategy) - not applicableapp/onchain_logger.py(if adding a strategy) - not applicableIf selected for payout: USDC
0x10DFE6771131BEc830A7a44D7Be45Ced0741b2b3.