Optimize websocket broadcast fanout#19
Open
naufalfx805-source wants to merge 1 commit into
Open
Conversation
|
@naufalfx805-source is attempting to deploy a commit to the dragoon4002's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #2
Scope
Optimizes the websocket fanout path in
hub/ws/manager.pyfor both agent-specific broadcasts and price broadcasts.Previously each subscriber was awaited one at a time, so one slow websocket delayed every other subscriber. The new path snapshots subscribers under the existing lock, sends the same payload concurrently with
asyncio.gather(..., return_exceptions=True), and still removes sockets whose send fails.I also replaced the runtime FastAPI
WebSocketimport with a smallProtocolso the manager can be unit-tested without requiring FastAPI just for type annotations.Benchmark
Synthetic local benchmark with 8 websocket subscribers, each
send_textdelayed by 30ms:This reflects the hot path where dashboard/price-feed clients are connected at the same time and one slow socket should not serialize the whole fanout.
Validation
python -m pytest tests/test_ws_manager.py -q-> 2 passedgit diff --cached --check-> passedIf selected for payout, I can provide a Base USDC address privately after acceptance.