Decompile func_80048600 and compile marina as C (us1)#14
Decompile func_80048600 and compile marina as C (us1)#14DodongoRex wants to merge 2 commits intoDrahsid:cleanup2024from
Conversation
|
This PR is for reservation only. I’ll push matching C code for func_80048600 to this branch once complete. |
|
Hey, thanks for working on this. |
|
Updated — PR is now targeting cleanup2024 and conflicts are resolved. |
|
Decompiled func_80048600 and converted marina segment to C. Build matches baserom; checksum OK. |
d4858de to
84d4a90
Compare
|
I refreshed the branch history on top of cleanup2024 to present a clean and linear diff for review. This PR now contains only the marina C conversion, the func_80048600 decomp, and required symbol/header updates. Build matches baserom; checksum OK. |
|
For each of the PRs you have open, let me know when they are ready to merge. |
|
Confirmed marina is compiled as C and contributes 0 bytes to .data/.rodata/.bss per build/mischiefmakers.map. Rebuild still matches (checksum OK, first_diff.py = No differences). Ready to merge. |
|
It looks like func_80048600 is in a NON_MATCHING guard - is the decompiled function actually matching? |
Reserving func_80048600 in src/49200.c per contributing guidelines.