Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable GKE autoscaling, use k8s_facts, fix pvc manager role #79

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Disable GKE autoscaling, use k8s_facts, fix pvc manager role #79

merged 5 commits into from
Oct 10, 2019

Conversation

dleehr
Copy link
Member

@dleehr dleehr commented Oct 10, 2019

  • Disables node pool autoscaling in GKE cluster (after lots of investigation in Implements simple k8s API retries calrissian#102)
  • Uses k8s_facts module instead of k8s_info. k8s_info is not yet released in ansible and k8s_facts will continue to work
  • adds a setup_bespin_api variable that can be set to False to avoid making bespin API calls - just create/delete clusters
  • Fixes issue in lando pvc manager role - needs resource as persistentvolumeclaims, not pvc

@dleehr dleehr requested a review from johnbradley October 10, 2019 18:08
johnbradley
johnbradley approved these changes Oct 10, 2019
View reviewed changes
Copy link
Contributor

@johnbradley johnbradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dleehr dleehr merged commit 837bec8 into master Oct 10, 2019
@dleehr dleehr deleted the tweak-gcloud-scaling branch October 10, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbradley johnbradley johnbradley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dleehr @johnbradley