-
Notifications
You must be signed in to change notification settings - Fork 29
Sktime and Pyspi Integration #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sktime and Pyspi Integration #82
Conversation
pyspi/base.py
Outdated
def _spi(self, data: Data, i: int = 0) -> float: | ||
raise NotImplementedError("Subclass must implement _spi.") | ||
|
||
@parse_univariate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not use these as decorators at all! But move the logic as a call into spi
.
@joshuabmoore Does the current API design for the class align well. |
@fkiraly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend you leave the current base classes untouched to ensure downwards compatibility. Add the new base class and try to write three substantially different spi as a descendant, include example usage in the concrete class docstring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- the original base class is still changed - can you revert that for now?
- the new base class looks mostly reasonable - I would suggest to move ahead and try implement two concrete SPI (perhaps slightly different ones).
- also, try to add tests for the SPI. For now, it is fine to loop over the concrete classes (once you have them)
@benfulcher @joshuabmoore @fkiraly
Solving issue #72
This initial implementation will be the starter modified base class of pyspi, and an attempt to make a unified public API. Keeping it draft until I finalize commits
These will be the scope of the upcoming commits:
BaseSPI
,Directed
andUndirected
.spi
andspi_mat
functions.Your reviews and guidance would be highly appreciated in this PR Thanks a lot!!