DYN-8461: Publishing a new version of a package should reflect correc…

…t version number (#15914)
DynamoDS · Mar 10, 2025 · a9a909a · a9a909a
1 parent b19e0b0
commit a9a909a
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/DynamoCoreWpf/Views/PackageManager/Controls/NumericUpDownControl.xaml.cs b/src/DynamoCoreWpf/Views/PackageManager/Controls/NumericUpDownControl.xaml.cs
@@ -141,10 +141,8 @@ private void inputField_PreviewTextInput(object sender, TextCompositionEventArgs
         // Handles the direct input of text (via keyboard)
         private void inputField_TextChanged(object sender, TextChangedEventArgs e)
         {
-            if (Int32.TryParse(inputField.Text, out int value))
-            {
-                Value = value.ToString();
-            };
+            Int32.TryParse(inputField.Text, out int value);
+            Value = value.ToString();
         }
 
         // When user clicks on the watermark label at first, hide the watermark and pass the focus to the input textbox

diff --git a/test/DynamoCoreWpf2Tests/PackageManager/PackageManagerUITests.cs b/test/DynamoCoreWpf2Tests/PackageManager/PackageManagerUITests.cs
@@ -204,6 +204,18 @@ public void PackagePublishNumericUpDownAllowsOnlyPositiveIntegerValues()
 
             isValidOutput = updownControl.IsValidInput("1");
             Assert.IsTrue(isValidOutput, "Should allow positive integers in numeric input.");
+
+            // Arrange
+            var inputField = updownControl.inputField;
+
+            // Act & Assert
+            Assert.AreEqual("0", updownControl.Value);
+
+            inputField.Text = "1";
+            Assert.AreEqual("1", updownControl.Value);
+
+            inputField.Text = "";
+            Assert.AreEqual("0", updownControl.Value);
         }
 
         [Test]