Replace CanBeResolvedTo with a non allocating version #15833
+6
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This function is in the hot path when loading a workspace, and takes a disproportionate amount of time given its complexity.
This PR reduces the time spent by this function by reducing time spent splitting and allocating new strings and string arrays and inside linq iterators. Instead this function now just compares the backing char spans of the two strings for end equality.
(Maybe this whole thing could be replaced with fullName.EndsWith(qualifiedName)?)
Performance
This reduces the time taken by this function by a substantial amount, but the function itself has low impact.
Old

New

Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
N/A
Reviewers
@mjkkirschner
FYIs
@dimven