Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The current json serialization implementation relies on using regexes and string replacement to fix up and change json files on read and write. It also serializes, deserializes then serializes the json again in some cases. This PR attempts to get around this by skipping some of the intermediate steps by using more Newtonsoft.Json features, like the SerializationBinder and a custom Json reader and writer.
Using more Newtonsoft.Json features also increases the flexibility if future changes to the json serialization is needed.
Performance
Input and Ouput parsing improvements for large graphs by using a dictionary to lookup nodes while deserializing.
Less .ToArray and .ToList copying.
Less string replacements during de/serialize.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
N/A
Reviewers
@mjkkirschner
FYIs
@dimven