Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json de/serialization #15854

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

bendikberg
Copy link
Contributor

Purpose

The current json serialization implementation relies on using regexes and string replacement to fix up and change json files on read and write. It also serializes, deserializes then serializes the json again in some cases. This PR attempts to get around this by skipping some of the intermediate steps by using more Newtonsoft.Json features, like the SerializationBinder and a custom Json reader and writer.

Using more Newtonsoft.Json features also increases the flexibility if future changes to the json serialization is needed.

Performance

Input and Ouput parsing improvements for large graphs by using a dictionary to lookup nodes while deserializing.
Less .ToArray and .ToList copying.
Less string replacements during de/serialize.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

N/A

Reviewers

@mjkkirschner

FYIs

@dimven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants