Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DYN-8358 fix broken tests #15918

Merged
merged 1 commit into from
Mar 11, 2025
Merged

DYN-8358 fix broken tests #15918

merged 1 commit into from
Mar 11, 2025

Conversation

chubakueno
Copy link
Contributor

@chubakueno chubakueno commented Mar 10, 2025 •
edited
Loading

Purpose

Fix broken tests which couldn't be previously validated in the pipeline.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

Fix broken ProtoCore Engine tests,

Reviewers

@QilongTang

FYIs

@BogdanZavu
@aparajit-pratap

@chubakueno chubakueno changed the title fix broken tests DYN-8358 fix broken tests Mar 11, 2025
github-actions[bot]
github-actions bot reviewed Mar 11, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the ticket for this pull request: https://jira.autodesk.com/browse/DYN-8358

@QilongTang QilongTang merged commit 6e23043 into master Mar 11, 2025
25 of 31 checks passed
@QilongTang QilongTang deleted the fix_broken_tests branch March 11, 2025 13:30
@QilongTang QilongTang added this to the 3.5 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@QilongTang QilongTang QilongTang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@chubakueno @QilongTang