Fix support for maxLevelCell = 0 in MPAS-Ocean
#83
Conversation
xylar
changed the title
maxLevelCell = 0 in MPAS-=OceanmaxLevelCell = 0 in MPAS-Ocean
|
@xylar I haven't had a chance to look at the output, but these changes resulted in QUwISC240's ssh_adjustment completing when ISC cells have |
xylar
force-pushed
the
ocn/fix-max-level-cell-zero
branch
from
47391d1 to
3db25e4
Compare
|
@cbegeman, I noticed that I started from a really old base here (6 months old). Not sure quite why but I was working from Polaris so maybe that was the current state of the E3SM-Project submodule where I was working. Anyway, I rebased and removed the one change that wasn't necessary anymore (and had a conflict). |
|
I'll do some more testing as soon as I have time. I would like to make a version of the IcoswISC30E3r5 mesh with |
|
@xylar Yes, I noticed that it was old but didn't want to change your branch too much. Thanks for rebasing! |
|
@xylar Have you checked if this is BFB lately? I could do this. Since we are moving on from this approach, it could be nice to get these fixes in so that it's possible for folks to build and run with |
|
@cbegeman, no, I haven't done any BFB testing of this but I would be very surprised if it isn't BFB on meshes that don't have I would still like to test it more on the ISOMIP+ test cases in Polaris, though, before I try to get it merged into E3SM just so I don't end up needing to do a second PR for things I missed. I think I might be able to get to that tomorrow or before early next week at the latest. |
|
@xylar That makes sense. Thanks! I wasn't sure if you were still going this route for ISOMIP+ and I wanted to make sure it didn't get stranded. |
There are various locations where
maxLevelCellwas previously assumed to be non-zero that this PR fixes.