Merged
Conversation
1 task
Contributor
⚡ Lighthouse CI ResultsPerformance scores will be available in the artifacts. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #764 +/- ##
=======================================
Coverage 61.09% 61.09%
=======================================
Files 127 127
Lines 10523 10523
=======================================
Hits 6429 6429
Misses 4094 4094
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guilbep
force-pushed
the
fix/528-default-0
branch
from
354e3ec to
87d554b
Compare
guilbep
approved these changes
Mar 30, 2026
guilbep
force-pushed
the
fix/528-default-0
branch
from
87d554b to
839ddba
Compare
Contributor
⚡ Lighthouse CI ResultsPerformance scores will be available in the artifacts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Guards the
formDefaultscomputed property against aundefinedvalidatedTotalsbefore accessingtotal_fte, and early-returnsundefinedwhen the store value is not yet available.Why is this needed?
Previously,
Math.round(fte)could be called withundefinedwhenvalidatedTotalshad not yet been populated, resulting inNaNbeing written as the default field value. This caused fields withdefaultFrom: 'total_fte'to render withNaNinstead of 0 or no value.Type of change
Please check the type that applies:
Related issues